Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an option to opt-out of data collection #27

Closed
jonalmeida opened this issue May 27, 2014 · 6 comments
Closed

Create an option to opt-out of data collection #27

jonalmeida opened this issue May 27, 2014 · 6 comments
Assignees
Labels
type:enhancement New features or improvements to existing features.
Milestone

Comments

@jonalmeida
Copy link
Contributor

Sample reference: https://segment.io/docs/libraries/ios/#how-can-my-users-opt-out-of-data-collection-

@jonalmeida jonalmeida added this to the Version 0.2.0 milestone May 27, 2014
@jonalmeida jonalmeida self-assigned this May 27, 2014
@alexanderdean
Copy link
Member

Neat feature

@jonalmeida
Copy link
Contributor Author

So I've been thinking about this for a bit. If the user chooses to opt-out, should we still collect events but never send them or do we just disable our self entirely?

The upside to the former, is that if they decide to turn it on we still have event data collected that can be useful.
The downsides - if the user doesn't turn the option on for a long time, we would have a massive database of events. Second, I'm not sure if that's a reasonable thing to do.. (i.e. maybe the user doesn't want to track events over a certain period?)

Thoughts @alexanderdean ? I'll keep this in mind over the weekend since this isn't urgent.

@alexanderdean
Copy link
Member

Hmm - I think we should stop collecting events period. If someone then switches it on again, I think they wouldn't expect or want events occuring during donottrack to suddenly be shared...

@jonalmeida
Copy link
Contributor Author

Chatted with Fred about this, and I can add the flag check in addTracker: before adding events to the buffer.

SnowplowRequest will check the buffer and database for events intermittently and stop when there aren't events. Consider finding a way to possibly shutdown the Request class as well.

@alexanderdean
Copy link
Member

Good idea

@jonalmeida
Copy link
Contributor Author

So with a LocationManager we may be turning the GPS on to get a location in complete_payload even if we're going to drop the events. That would be pretty wrong if we did that, so we'd need to drop out at the beginning of complete_payload or somewhere before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New features or improvements to existing features.
Projects
None yet
Development

No branches or pull requests

3 participants