Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to default remote configuration and don't update unless remote configuration is newer (close #779) #781

Merged
merged 3 commits into from
Jun 2, 2023

Conversation

matus-tomlein
Copy link
Contributor

Issue #779

Adds an option to specify the configuration version for default configuration in remote config. This version is then used to compare the default to the fetched configuration and only update it in case the fetched one has a newer version.

The benefit is that the default tracker is not recreated from the fetched configuration if it is the same. This also means that the session is not reset.

@matus-tomlein matus-tomlein force-pushed the issue/779-default_config_version branch from 2472676 to cc71fe1 Compare May 22, 2023 08:41
@matus-tomlein matus-tomlein force-pushed the issue/779-default_config_version branch from cc71fe1 to 76ec789 Compare May 22, 2023 08:46
@matus-tomlein matus-tomlein requested a review from mscwilson May 25, 2023 16:14
Copy link
Contributor

@mscwilson mscwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (wrong base branch)

Tests/Configurations/TestRemoteConfiguration.swift Outdated Show resolved Hide resolved
Tests/Configurations/TestRemoteConfiguration.swift Outdated Show resolved Hide resolved
@matus-tomlein matus-tomlein changed the base branch from master to release/5.2.0 June 2, 2023 12:08
@matus-tomlein matus-tomlein merged commit 63fa612 into release/5.2.0 Jun 2, 2023
@matus-tomlein matus-tomlein deleted the issue/779-default_config_version branch June 2, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants