Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Stream Enrich to 0.18.0 #174

Closed
BenFradet opened this issue Jul 12, 2018 · 12 comments
Closed

Bump Stream Enrich to 0.18.0 #174

BenFradet opened this issue Jul 12, 2018 · 12 comments
Assignees
Milestone

Comments

@BenFradet
Copy link
Contributor

there is a huge impedance mismatch between snowplow/snowplow release frequency and mini's which defeats the purpose of a qa pipeline (e.g. with the pii enrichment)

@alexanderdean
Copy link
Member

Should this go into the current release?

@BenFradet BenFradet added this to the Version 0.6.0 milestone Jul 12, 2018
@BenFradet
Copy link
Contributor Author

yup, sorry @oguzhanunlu 😞

@oguzhanunlu
Copy link
Member

I like it dynamic @BenFradet ! Should we bump to 0.17.0 ? It is latest stable available from bintray right now.

@oguzhanunlu oguzhanunlu mentioned this issue Jul 12, 2018
18 tasks
@BenFradet
Copy link
Contributor Author

it'll basically be a race between mini 0.6.0 and R107, either you win and it'll be 0.17.0 or Rostyslav wins and it'll be 0.18.0 :D

@oguzhanunlu oguzhanunlu changed the title Bump Stream Enrich Bump Stream Enrich to 0.17.0 Jul 12, 2018
@BenFradet
Copy link
Contributor Author

Note that this version of enrich needs a new nsq topic (for pii events)

@jbeemster
Copy link
Member

So I think for the sake of keeping the mini working this should be disabled - no one will be able to consume the PII Stream - the data in the PII Stream will also not be surfaced anywhere. Badly configuring the PII enrichment or stream enrich will also break things as the settings need to map together very accurately.

I would vote for not allowing a PII stream at all at this point.

@BenFradet
Copy link
Contributor Author

the data in the PII Stream will also not be surfaced anywhere

? it'll be in NSQ and people want to test their pii enrichment in mini

@BenFradet
Copy link
Contributor Author

BenFradet commented Jul 13, 2018

discussed with Josh and subsequently logged snowplow/snowplow#3828 as it is very much impractical, we can't realistically enable the pii enrichment in its version 2-0-0 atm...

@BenFradet
Copy link
Contributor Author

the validation is only performed for Kinesis (which is a bug snowplow/snowplow#3829) so we can enable the new pii enrichment as it is.

a new nsq topic will need to be created.

@oguzhanunlu oguzhanunlu removed this from the Version 0.6.0 milestone Jul 13, 2018
@oguzhanunlu oguzhanunlu removed their assignment Jul 13, 2018
@BenFradet
Copy link
Contributor Author

The decision was to provide a default pii enrichment which does nothing.

@BenFradet BenFradet added this to the Version 0.6.0 milestone Jul 16, 2018
@alexanderdean
Copy link
Member

We will also need to update the documentation to explain how to update that enrichment if you want to change the configuration (e.g. the NSQ topic name must not be changed).

@BenFradet BenFradet changed the title Bump Stream Enrich to 0.17.0 Bump Stream Enrich to 0.18.0 Jul 17, 2018
@BenFradet
Copy link
Contributor Author

Bumped to 0.18.0 since we'll be releasing it today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants