-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Stream Enrich to 0.18.0 #174
Comments
Should this go into the current release? |
yup, sorry @oguzhanunlu 😞 |
I like it dynamic @BenFradet ! Should we bump to |
it'll basically be a race between mini 0.6.0 and R107, either you win and it'll be 0.17.0 or Rostyslav wins and it'll be 0.18.0 :D |
Note that this version of enrich needs a new nsq topic (for pii events) |
So I think for the sake of keeping the mini working this should be disabled - no one will be able to consume the PII Stream - the data in the PII Stream will also not be surfaced anywhere. Badly configuring the PII enrichment or stream enrich will also break things as the settings need to map together very accurately. I would vote for not allowing a PII stream at all at this point. |
? it'll be in NSQ and people want to test their pii enrichment in mini |
discussed with Josh and subsequently logged snowplow/snowplow#3828 as it is very much impractical, we can't realistically enable the pii enrichment in its version 2-0-0 atm... |
the validation is only performed for Kinesis (which is a bug snowplow/snowplow#3829) so we can enable the new pii enrichment as it is. a new nsq topic will need to be created. |
The decision was to provide a default pii enrichment which does nothing. |
We will also need to update the documentation to explain how to update that enrichment if you want to change the configuration (e.g. the NSQ topic name must not be changed). |
Bumped to 0.18.0 since we'll be releasing it today |
there is a huge impedance mismatch between snowplow/snowplow release frequency and mini's which defeats the purpose of a qa pipeline (e.g. with the pii enrichment)
The text was updated successfully, but these errors were encountered: