Add CacheTtl to DataConf struct in iglu_resolver_model #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When CacheTtl isn't in that struct, CacheTtl has been removed from iglu_resolver.json when adding external iglu with '/external-iglu' endpoint and that leads to caching schemas indefinitely.
Add go.mod and go.sum files
istreeter
approved these changes
Jul 8, 2024
spenes
force-pushed
the
fix/enrich-cache-big
branch
from
c3c9558 to
4754128
Compare
spenes
force-pushed
the
fix/enrich-cache-big
branch
from
4754128 to
467ecc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ref: PDP-1241
Main purpose of this PR is fixing the bug that leads to caching schemas indefinitely in Enrich. This bug is fixed by adding
cacheTtlfield to DataConf struct in iglu_resolver_model in control plane api.Other changes:
cacheTtlin the iglu-resolver.json is increased to 60 seconds to avoid sending too much request to Iglu registries.go.modandgo.sumfiles.