-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic type for SelfDescribing event data #156
Comments
SelfDescribing
event
Thanks for the suggestion @henbrand, that's really cool and a good step towards type safety! It would be awesome if you could make a PR for this. I just have one concern regarding the diff that you sent above – the |
@matus-tomlein - could you give me correct permissions (Direct Access should work) to open a PR? |
@henbrand Can you please fork the repository, make the change and submit a PR to this repository? That should work without needing any extra permissions. Let me know if there is any problem with it. |
SelfDescribing
event
Hi! 👋
For additional type safety I wanted to be able to type the data object for
trackSelfDescribingEvent
, currently I have patched the library to allow me to do so. Let me know if you'd like me to open a pull request!Here is the diff that solved my problem:
The text was updated successfully, but these errors were encountered: