Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android tracker version to 1.5.x #91

Closed
MarlosAugusto opened this issue Sep 2, 2020 · 5 comments
Closed

Fix Android tracker version to 1.5.x #91

MarlosAugusto opened this issue Sep 2, 2020 · 5 comments
Labels
type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Milestone

Comments

@MarlosAugusto
Copy link

In the last update on the native tracker for android, the "waitForEventStore" method by Emitter was removed.

To Reproduce
use snowplow-react-native-tracker and compile some project.

Screenshots
snowplow-react-native-tracker code (being used in a project):
image

build error:
image

Smartphone:

  • Android emulator(in this case the version or model of the smartphone is indifferent.
@MarlosAugusto MarlosAugusto added the type:defect Bugs or weaknesses. The issue has to contain steps to reproduce. label Sep 2, 2020
@colmsnowplow
Copy link
Contributor

Thanks for flagging @MarlosAugusto, I think I see how that happened, working on a fix now.

@colmsnowplow colmsnowplow changed the title snowplow-android-tracker update causes build error Fix Android tracker version to 1.5.x Sep 3, 2020
@colmsnowplow
Copy link
Contributor

The method in question causes the tracker to wait for the SQLite Database to initialise before proceeding, to prevent data loss. v1.6 of the android tracker uses a different DB with no need to do this, and deprecates the method.

Short term solution is to fix android tracker version to 1.5.+, to unblock those that are having this issue. Longer term, we remove that line, use the latest version, and test that this doesn't impact anything else (separate issue for that: #92).

@colmsnowplow colmsnowplow added this to the release/0.1.1 milestone Sep 3, 2020
@MarlosAugusto
Copy link
Author

OK :)

@colmsnowplow
Copy link
Contributor

v0.1.1 is now published and should resolve the issue. Thanks again for reporting @MarlosAugusto

@MarlosAugusto
Copy link
Author

amazing, thanks for answering so quickly and for nothing :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Projects
None yet
Development

No branches or pull requests

2 participants