Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #37 Handle multi-chunk pax extended header data #39

Merged
merged 4 commits into from
Jan 6, 2024
Merged

Conversation

mpilgrem
Copy link
Collaborator

@mpilgrem mpilgrem commented Jan 5, 2024

Also applies a more sophisticated paxSpec test.

The input example ByteString is chopped up into pieces and the extended payload is a very long filepath record.

Also fixes a bug in the offsets in the example's headers.
@mpilgrem
Copy link
Collaborator Author

mpilgrem commented Jan 6, 2024

Reviewed, and tested independently, by @bitc: #37 (comment).

@mpilgrem mpilgrem merged commit 76e07d0 into master Jan 6, 2024
5 checks passed
@mpilgrem mpilgrem deleted the fix37 branch January 6, 2024 14:23
@mpilgrem
Copy link
Collaborator Author

mpilgrem commented Jan 6, 2024

@snoyberg, may I ask you to release tar-conduit-0.4.1 on Hackage? It is a bug fix release, incorporating this pull request.

@snoyberg
Copy link
Owner

snoyberg commented Jan 6, 2024

No problem, done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants