-
Notifications
You must be signed in to change notification settings - Fork 24
fix(code-analysis): disabled code analysis #116
Conversation
disable code argument with off-only option
added GitHub ci workflow
revised GitHub ci workflow
…option # Conflicts: # README.md
snyk security scans only at push with secret token use
snyk security scans only at push with secret token use at build-test-monitor
name: snyk_security | ||
|
||
# Controls when the workflow will run | ||
on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's still do the snyk test on PRs if they are not from a fork. its a little more work but still most of the repo changes will be from internal PRs and will still be useful to have this in the PR check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
included snyk* jobs conditional checks to internal PRs from this base repo
.circleci/config.yml
Outdated
@@ -1,4 +1,17 @@ | |||
version: 2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we just delete this file? we don't want to have anything related to circle CI left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted
snyk security scans trigger on PR to master from same repo branches
snyk security jobs trigger on PR to master from same repo branches
snyk security jobs trigger on PR to master from same repo branches
snyk security jobs trigger on PR to master from same repo branches
disable code argument with off-only option