Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: Added DueDate support for creating Jira #185

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Dec 2, 2022

Added the optional flag for the due date built-in flag. Updated README with instructions

  • Tests written and linted ℹ︎
  • Documentation written ℹ︎
  • Commit history is tidy ℹ︎

What this does

Bringing in #179

@lili2311 lili2311 requested a review from a team as a code owner December 2, 2022 18:31
@vallieres
Copy link
Contributor

Hi @lili2311 I just realized you had an issue merging my branch 😞
I can't propose a change to this branch, but here's the change to fix the tests:

diff --git a/jira_utils.go b/jira_utils.go
index 16f9abe..60a0711 100644
--- a/jira_utils.go
+++ b/jira_utils.go
@@ -63,7 +63,7 @@ func getJiraTicketId(responseData []byte) *JiraDetailForTicket {
        return jiraIssueDetails
 }
 
-func formatJiraTicket(jsonVuln jsn.Json, projectInfo jsn.Json, flags optionalFlags) *JiraIssue {
+func formatJiraTicket(jsonVuln jsn.Json, projectInfo jsn.Json, flags flags) *JiraIssue {
 
        issueData := jsonVuln.K("issueData")

@lili2311 lili2311 force-pushed the feat/due-date branch 2 times, most recently from 722f434 to 1cf240b Compare December 16, 2022 16:13
Added the optional flag for the due date built-in flag.
Updated README with instructions
@lili2311 lili2311 self-assigned this Dec 16, 2022
@lili2311 lili2311 merged commit 3d877de into develop Dec 16, 2022
@lili2311 lili2311 deleted the feat/due-date branch December 16, 2022 16:16
lili2311 added a commit that referenced this pull request Dec 16, 2022
* minor: Adding new flag: canAutoPR (#187)

Thi is to address #182

Co-authored-by: Troy Havelock <[email protected]>

* minor: Added DueDate support for creating Jira (#185)

Added the optional flag for the due date built-in flag.
Updated README with instructions

Co-authored-by: Alexandre Vallières-Lagacé <[email protected]>

Co-authored-by: Troy Havelock <[email protected]>
Co-authored-by: Alexandre Vallières-Lagacé <[email protected]>
jlourenc pushed a commit that referenced this pull request Mar 31, 2023
Added the optional flag for the due date built-in flag.
Updated README with instructions

Co-authored-by: Alexandre Vallières-Lagacé <[email protected]>
jlourenc pushed a commit that referenced this pull request Mar 31, 2023
Added the optional flag for the due date built-in flag.
Updated README with instructions

Co-authored-by: Alexandre Vallières-Lagacé <[email protected]>
lili2311 added a commit that referenced this pull request Jun 22, 2023
major: Migrate to REST List Projects API

This is to address #182

Co-authored-by: Troy Havelock <[email protected]>

* minor: Added DueDate support for creating Jira (#185)

Added the optional flag for the due date built-in flag.
Updated README with instructions

Co-authored-by: Alexandre Vallières-Lagacé <[email protected]>

* minor: align urls with the recommended domains and paths (#192)

Switch from:
- `snyk.io/api` to `api.snyk.io`
- `api.snyk.io/api` to `api.snyk.io`
- `snyk.io/vuln` to `security.snyk.io/vuln`
- `api.snyk.io/v3` to `api.snyk.io/rest`

* minor: use public utility container for github releasing tool (#194)
* major: Migrate to REST List Projects API (#199)


---------
Co-authored-by: Jeff B <[email protected]>
Co-authored-by: Troy Havelock <[email protected]>
Co-authored-by: Alexandre Vallières-Lagacé <[email protected]>
Co-authored-by: Jérémy Lourenço <[email protected]>
Co-authored-by: aarlaud <[email protected]>
Co-authored-by: Jeff B <[email protected]>
@@ -31,6 +31,7 @@ type Field struct {
Assignees *Assignee `json:"assignee,omitempty"`
Priority *PriorityType `json:"priority,omitempty"`
Labels []string `json:"labels,omitempty"`
DueDate string `json:"dueDate,omitempty"`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be => DueDate string json:"due**d**ate,omitempty" D small letter

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be different for you. I've been running like this for months and it matched our Jira Cloud due date field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants