Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make driftctl SSO ready #708

Merged
merged 3 commits into from
Jun 30, 2021
Merged

Make driftctl SSO ready #708

merged 3 commits into from
Jun 30, 2021

Conversation

wbeuil
Copy link
Contributor

@wbeuil wbeuil commented Jun 28, 2021

Q A
🐛 Bug fix? no
🚀 New feature? yes
⚠ Deprecations? no
❌ BC Break no
🔗 Related issues #53 and #85
❓ Documentation yes

Description

First commit to bump aws-sdk using go get -u github.com/aws/aws-sdk-go.
Second commit to refactor and to make it similar for all AWS suppliers with the same naming and mocks.

@wbeuil wbeuil requested a review from a team as a code owner June 28, 2021 16:26
Copy link
Contributor

@lotoussa lotoussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems relevant

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #708 (0ca2866) into main (63c1e9b) will not change coverage.
The diff coverage is 52.17%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #708   +/-   ##
=======================================
  Coverage   70.43%   70.43%           
=======================================
  Files         207      207           
  Lines        6328     6328           
=======================================
  Hits         4457     4457           
  Misses       1580     1580           
  Partials      291      291           
Impacted Files Coverage Δ
pkg/remote/aws/dynamodb_table_supplier.go 62.96% <0.00%> (ø)
pkg/remote/aws/init.go 0.00% <0.00%> (ø)
pkg/remote/aws/repository/cloudfront_repository.go 66.66% <ø> (ø)
pkg/remote/aws/repository/ec2_repository.go 82.73% <ø> (ø)
pkg/remote/aws/repository/lambda_repository.go 74.07% <ø> (ø)
pkg/remote/aws/repository/rds_repository.go 80.00% <ø> (ø)
pkg/remote/aws/repository/sns_repository.go 74.07% <ø> (ø)
pkg/remote/aws/repository/sqs_repository.go 66.66% <ø> (ø)
pkg/remote/aws/cloudfront_distribution_supplier.go 58.33% <50.00%> (ø)
pkg/remote/aws/db_instance_supplier.go 52.38% <50.00%> (ø)
... and 38 more

@eliecharra eliecharra merged commit ef1880d into main Jun 30, 2021
@eliecharra eliecharra deleted the sso branch June 30, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants