Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include subgroups per https://docs.gitlab.com/ee/api/groups.html#list… #397

Closed
wants to merge 1 commit into from

Conversation

jesuscmartinez
Copy link

…-a-groups-projects

  • Tests written and linted ℹ︎
  • Documentation written in Wiki/README
  • Commit history is tidy & follows Contributing guidelines ℹ︎

What this does

Explain why this PR exists

Notes for the reviewer

Instructions on how to run this locally, background context, what to review, questions…

More information

Screenshots

Visuals that may help the reviewer

@jesuscmartinez jesuscmartinez requested a review from a team as a code owner December 7, 2022 19:20
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jesus Martinez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lili2311
Copy link
Contributor

lili2311 commented Dec 8, 2022

hi @jesuscmartinez could you please provide some context on why this change was needed?

@jesuscmartinez
Copy link
Author

As is only the projects directly under a group are gathered. When groups have sub groups, the sub group's projects are not included. This will now include all projects under a group including the sub group's projects.

@lili2311
Copy link
Contributor

lili2311 commented Dec 28, 2022

@jesuscmartinez are you expecting the sub-group to be treated like it is another group or simply to have the sub-groups projects show up in the parent group? When the import is used to mirror Gitlab into Snyk we take the Groups as Snyk Org names and then all repos under that group will be imported into that Snyk Org. Is a sub-group in this case another Org in Snyk or simply you are after the missing projects to show up in the parent Group?

At the moment we list all available groups https://docs.gitlab.com/ee/api/groups.html and this will include the sub-groups, so we should be picking up projects from the sub-groups as well. I will review the tests to confirm

@lili2311
Copy link
Contributor

@jesuscmartinez After reviewing the tests it seems at least the latest version was dropping some projects, fix is in progress #416 once released please try again and confirm you are getting your projects. The tool is designed to treat sub-groups the same as groups at the moment.

@lili2311
Copy link
Contributor

@jesuscmartinez did you get a chance to review? Can this be closed?

@lili2311 lili2311 closed this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants