Merge pull request #307 from snyk/fix/typescript-promise-issues

Fix/typescript promise issues
snyk · Nov 20, 2020 · a974797 · a974797
2 parents a4b61d4 + 249936b
commit a974797
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/lib/docker.ts b/lib/docker.ts
@@ -90,7 +90,7 @@ class Docker {
 
     const modem = new Modem();
 
-    return new Promise((resolve, reject) => {
+    return new Promise<void>((resolve, reject) => {
       modem.dial(request, (err, stream: Stream) => {
         if (err) {
           return reject(err);

diff --git a/lib/stream-utils.ts b/lib/stream-utils.ts
@@ -42,13 +42,13 @@ async function streamToHash(
   stream: Readable,
   hashAlgorithm: string,
 ): Promise<string> {
-  return new Promise((resolve, reject) => {
+  return new Promise<string>((resolve, reject) => {
     const hash = crypto.createHash(hashAlgorithm);
     hash.setEncoding(HASH_ENCODING);
 
     stream.on("end", () => {
       hash.end();
-      resolve(hash.read());
+      resolve(hash.read().toString(HASH_ENCODING));
     });
 
     stream.on("error", (error) => reject(error));

diff --git a/package.json b/package.json
@@ -45,7 +45,7 @@
     "uuid": "^8.2.0"
   },
   "devDependencies": {
-    "@types/node": "^8.10.48",
+    "@types/node": "8.10.48",
     "@types/sinon": "5.0.5",
     "@types/tar-stream": "^1.6.1",
     "@types/tmp": "^0.2.0",
@@ -57,7 +57,7 @@
     "tsc-watch": "^4.2.8",
     "tslint": "^5.16.0",
     "tslint-config-prettier": "^1.18.0",
-    "typescript": "^4.0.3",
+    "typescript": "4.0.3",
     "jest": "^26.4.2",
     "ts-jest": "^26.4.0"
   }