Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable certificate trust correctly #55

Merged
merged 2 commits into from
Dec 18, 2024
Merged

fix: disable certificate trust correctly #55

merged 2 commits into from
Dec 18, 2024

Conversation

soniqua
Copy link
Contributor

@soniqua soniqua commented Dec 18, 2024

What

  • Correctly disable certificate trust
  • Correct use of .Values.disableAllCertificateTrust

@soniqua soniqua requested a review from a team as a code owner December 18, 2024 10:40
@CLAassistant
Copy link

CLAassistant commented Dec 18, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@soniqua soniqua closed this Dec 18, 2024
@soniqua soniqua reopened this Dec 18, 2024
@soniqua soniqua requested review from aarlaud and removed request for shuaibmunshi December 18, 2024 11:49
@soniqua soniqua merged commit 1871613 into rc Dec 18, 2024
7 checks passed
@soniqua soniqua deleted the fix/certificate-trust branch December 18, 2024 11:50
@soniqua soniqua mentioned this pull request Dec 19, 2024
Merged
soniqua added a commit that referenced this pull request Dec 19, 2024
@soniqua @saumilmac
chore: new release (#58)
8f918c0 
* ci: fix vuln (#54)

* fix: correct ca certificate mounting (#56)

* fix: disable certificate trust correctly (#55)

* docs: re-order values file (#57)

---------

Co-authored-by: Saumil Macwan <[email protected]>
soniqua added a commit that referenced this pull request Dec 19, 2024
@soniqua
fix: disable certificate trust correctly (#55)
edce3fd
soniqua added a commit that referenced this pull request Dec 19, 2024
@soniqua @saumilmac
chore: new release (#58)
03da584 
* ci: fix vuln (#54)

* fix: correct ca certificate mounting (#56)

* fix: disable certificate trust correctly (#55)

* docs: re-order values file (#57)

---------

Co-authored-by: Saumil Macwan <[email protected]>
soniqua added a commit that referenced this pull request Dec 19, 2024
@soniqua
fix: disable certificate trust correctly (#55)
8184e43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarlaud aarlaud aarlaud approved these changes

@pavel-snyk pavel-snyk Awaiting requested review from pavel-snyk pavel-snyk is a code owner automatically assigned from snyk/hybrid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soniqua @CLAassistant @aarlaud