Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Thomas Pornin's Feedback #4

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Implement Thomas Pornin's Feedback #4

merged 2 commits into from
Oct 1, 2020

Conversation

soatok
Copy link
Owner

@soatok soatok commented Oct 1, 2020

Changes resulting from reedback from @pornin (Thank you! ❤️)

  • Rename negate to not (since negate() implies "make negative" which isn't what this function dodes)
  • Fix compare() with large ranges

@soatok soatok merged commit f4f2aff into master Oct 1, 2020
@soatok soatok deleted the pornin-feedback branch October 1, 2020 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant