Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for 'reveal' in a subdir (#903) #905

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

ochanism
Copy link
Contributor

resolve #903

I've made a bug patch for reveal command and added a test case for covering the case.

Copy link
Owner

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

tests/test_reveal.bats Outdated Show resolved Hide resolved
tests/test_reveal.bats Show resolved Hide resolved
Copy link
Owner

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@sobolevn sobolevn merged commit b037861 into sobolevn:master Jul 19, 2022
@joshrabinowitz
Copy link
Collaborator

If I'm reading correctly this merged PR is causing tests to fail?

@sobolevn
Copy link
Owner

Strange, ci was green 🤔

@joshrabinowitz
Copy link
Collaborator

It's back to green after I reran tests. Transient error it appears.

@joshrabinowitz
Copy link
Collaborator

We need to release a new version of git-secret to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reveal command is failed in the sub directory
3 participants