fix: ignores WebSocket connection with same sid after upgrade
#46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second websocket created after an upgrade should gracefully close and not throw an error as specified in the official implementation. Moreover in the same test for the
socket.io
test suite the implementation wait for the second websocket to gracefully close.Here is an example of engine.io server which fails at validating this test:
It would be nice to be able to use a separate engine.io test suite in CI for our rust server implementation socketioxide.
Closes socketio/socket.io-protocol#29
Closes Totodore/socketioxide#15