1.8.x: Upgrade to [email protected]
#495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eordano
changed the title
[email protected][email protected]
|
Any idea why the build would fail? |
|
@darrachequesne it looks like failures happen when using the uws engine ( |
|
Also 0.10 and 0.12 results seem to be false positives. |
This was referenced Apr 17, 2017
|
any reason socketio is not merging this? |
|
@eordano thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug with a clean install of a server using
socket.io; the underlying cause was fixed inws.Current behavior: The connection can not be established due to a bug when using
bufferUtil.The bug is described here: websockets/ws#1010