Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/policy #273

Merged
merged 5 commits into from
Aug 31, 2011
Merged

Feature/policy #273

merged 5 commits into from
Aug 31, 2011

Conversation

3rd-Eden
Copy link
Contributor

@3rd-Eden 3rd-Eden commented Aug 6, 2011

I discovered this nice hidden undocumented gem in the web-socket-js project when I was skimming through the source.. By default it will retrieve it from the by default suggest port number 843 but this port requires root privileges. So normally people would set up IP tables or proxies to do port forwarding of 843 to a non root port.

This just makes all that stuff so much easier, you can just define a different port on the server and client and you are done with it ^_^ <3

Tested it, and it works like charm.. We might want to set a non root port by default both on the server and on the client..

Opinions on that are more than welcome.

@3rd-Eden
Copy link
Contributor Author

3rd-Eden commented Aug 6, 2011

My personal preference for a default non root port goes to 2030 (If I remember correctly, socket.io was first released on March 17 2010? 03 + 17 + 2011 = 2030 :D)

@dshaw
Copy link

dshaw commented Aug 9, 2011

:) Ah, great. Hope this lands soon.

@3rd-Eden
Copy link
Contributor Author

3rd-Eden commented Aug 9, 2011

@dshaw same, just got to make one more small adjustment, we want to use a non root port by default. We just have to come up with a port number for it :)

@dshaw
Copy link

dshaw commented Aug 9, 2011

:2030 works. I actually use this to force the request on :80 to deal with fire wall request swallowing.

@tommedema
Copy link

Isn't this about websockets? How is it related to flash sockets and root being required? :)

@3rd-Eden
Copy link
Contributor Author

@tommedema this isn't about websockets, the flashsocket requires a net.Server that can respond the flashplayer's origin authentication / crossdomain.xml requests.

Currently they default to port 843, but with this fix that is no longer needed

@tommedema
Copy link

@3rd-Eden, ah. That's excellent. Great find.

rauchg added a commit that referenced this pull request Aug 31, 2011
@rauchg rauchg merged commit 0419213 into socketio:master Aug 31, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants