Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting return_buffers to true causes errors #185

Closed
jjb opened this issue Jan 31, 2017 · 3 comments
Closed

setting return_buffers to true causes errors #185

jjb opened this issue Jan 31, 2017 · 3 comments

Comments

@jjb
Copy link

jjb commented Jan 31, 2017 •
edited
Loading

I recently updated to the latest version (3.1.0) from 1.0.0. After doing this, exactly every other message that I emit is ignored. I bisected, and the version where this problem starts is 3.0.0. I bisected further and found that the bug was introduced in 73ce3ea. removing return_buffers: true from my code solved the problem.

So, maybe it's worth putting a warning in the changelog about this. I would contribute a PR but i don't know the technology well enough to word it correctly.

Thanks for a great project!
@jjb jjb changed the title setting return_buffer to true causes errors setting return_buffers to true causes errors Jan 31, 2017
@picometer
Copy link

picometer commented Feb 2, 2017 •
edited
Loading

I had the same error and return_buffers: true is the problem as you posted. Thanks.

@darrachequesne
Copy link
Member

I was unable to reproduce the issue, but I added a note here, what do you think?

@jjb
Copy link
Author

jjb commented Feb 6, 2017

Cool

how about to History.md as well

@darrachequesne darrachequesne mentioned this issue Feb 6, 2017
Merged
BenLubar added a commit to BenLubar/NodeBB that referenced this issue Feb 10, 2017
@BenLubar
Fix forum instances using Redis dropping socket.io messages.
9fb16e3 
Bug introduced in b08acd1.

https://github.com/socketio/socket.io-redis/releases/tag/3.0.0
socketio/socket.io-redis-adapter#185
@BenLubar BenLubar mentioned this issue Feb 10, 2017
Merged
@JohnXLivingston JohnXLivingston mentioned this issue Sep 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jjb @picometer @darrachequesne