Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide way to handle errors #96

Closed
wants to merge 1 commit into from

Conversation

KimSchneider
Copy link

provide a simple way to handle erros of both client connections. This way the app can be terminated gracefully if connection to redis is lost or any other errors occur.

provide a simple way to handle erros of both client connections. This way the app can be terminated gracefully if connection to redis is lost or any other errors occur.
@LordMajestros
Copy link

Thanks for this but isn't this better left to the programmer? That is provide your own pub and sub clients and handle their errors?

@KimSchneider
Copy link
Author

Well, providing pub and sub clients is some kind of weird workaround when working with redis, so I would suggest handling the errors within the module. Why should all developers code the same code?

But you are right on that one page, you should make it possible to pass all possible redis connect params (like max reconnect, etc.) or simply say "insert your own client here".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants