Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no socket.io.js in lib #38

Closed
termie opened this issue Aug 20, 2010 · 2 comments
Closed

no socket.io.js in lib #38

termie opened this issue Aug 20, 2010 · 2 comments

Comments

@termie
Copy link

termie commented Aug 20, 2010

this breaks all existing users of this code and is a departure from the common pattern of putting your code in ./lib/

@rauchg
Copy link
Contributor

rauchg commented Aug 25, 2010

Actually, this is the best pattern. This way, you can

require.paths.unshift('path/to/socket.io/lib')

and require it as a "singleton":

require('socket.io')

This way, we also achieve npm compatibility without enforcing it.

@termie
Copy link
Author

termie commented Aug 25, 2010

the example code you just mentioned does not work, specifically due to the issue I described.

darrachequesne pushed a commit that referenced this issue Jul 4, 2024
… to also have the .once removed as it's wrapped in a function. Anyways this alone is enough to close bug #103 . Because we now have a once listener we can easily fix #38
darrachequesne pushed a commit that referenced this issue Jul 8, 2024
Use travis matrix for better test runs
darrachequesne pushed a commit that referenced this issue Jul 8, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants