-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sec-WebSocket-Location hardcoded to ws:// #40
Comments
I think I sent a pull request earlier, but here's the change which fixes this issue so everyene else can find and use it in the interim: http://github.com/jdub/Socket.IO-node/commit/eadd5c95115695de3ebb0586c41a330a8f391019 |
Oh, that change was silly. This one is better. :-) Pull request submitted. http://github.com/jdub/Socket.IO-node/commit/7db9a8ffe0555417e1e4abe7816812c76117c219 |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Pretty simple hard-coding problem in lib/socket.io/transports/websocket.js, which was the only catch an otherwise flawless experience. :-) Will attach a patch.
The text was updated successfully, but these errors were encountered: