-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad headers in jsonp-polling, xhr-polling #58
Comments
Fixed |
darrachequesne
added a commit
that referenced
this issue
Jul 4, 2024
darrachequesne
added a commit
that referenced
this issue
Jul 8, 2024
Require base64-arraybuffer module conditionally.
darrachequesne
pushed a commit
that referenced
this issue
Jul 8, 2024
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jsonp-polling and xhr-polling require encoding parameter in Content-type header (some browsers decode data got with this methods with page's encoding)
Content-length gets corrupted if non-english symbols are sent because it requires number of bytes but string.length returns number of symbols in string.
This issue is fixed in http://github.com/SlNPacifist/Socket.IO-node branch
Buffer.byteLength is used, but Buffer became global object only in node.js v 0.1.103, so after merging with branch that will become the least version needed.
The text was updated successfully, but these errors were encountered: