Memory leak in namespaces

[samlown]

Hi,

While trying to produce a list of sockets currently connected to the server I discovered a minor memory leak. When using several namespaces, for some reason each connection to the server creates a new socket instance in each namespace's object, despite only one being required.

When the client disconnects, only the specified namespace's socket object is removed, all the other namespaces are left with an empty socket instance with disconnected == false.

This can be seen by listing a namespaces sockets, connecting to a different namespace, closing, then refreshing the first namespaces sockets list. Quick pseudo example:

io.of('/drivers').sockets.length == io.of('/riders').sockets.length == 0
# Client connects to '/drivers'
io.of('/drivers').sockets.length == io.of('/riders').sockets.length == 1
# Client disconnects from '/drivers'
io.of('/drivers').sockets.length == 0
io.of('/riders').sockets.length == 1

Cheers,
sam

[einaros]

Thank you for this. I'll try reproducing and get back to you shortly.

[einaros]

That ought to cover it.

[samlown]

Awesome!

I can't help thinking though that it might also be beneficial to not insert the socket object into the other namespaces in the first place. Is this possible or have I mis-understoud how a part of the system works?