Fix SSLServer#accept failures causing accept loop to exit. #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've observed failures in production in falcon virtual where the proxy stops responding. I believe this is the root cause of the problem - server.accept is failing and (1) killing the accept loop or (2) hanging.
(1) will cause the process to exit and restart, but (2) will cause the proxy to stop accepting new connections which is far more problematic.
This is a regression on
io-endopint
, asAsync::IO::Endpoint
implemented this a little differently.Types of Changes
Contribution