Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSLServer#accept failures causing accept loop to exit. #10

Merged
merged 4 commits into from
May 10, 2024

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented May 9, 2024

I've observed failures in production in falcon virtual where the proxy stops responding. I believe this is the root cause of the problem - server.accept is failing and (1) killing the accept loop or (2) hanging.

(1) will cause the process to exit and restart, but (2) will cause the proxy to stop accepting new connections which is far more problematic.

This is a regression on io-endopint, as Async::IO::Endpoint implemented this a little differently.

Types of Changes

  • Bug fix.

Contribution

@ioquatix ioquatix merged commit 09bbe1c into main May 10, 2024
30 of 36 checks passed
@ioquatix ioquatix deleted the fix-ssl-accept-failures branch May 10, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant