Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure on go version 1.12 #21

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

joseph-v
Copy link
Collaborator

@joseph-v joseph-v commented Jun 13, 2020

This PR fixes issue #20
The default value of GO111MODULE is different in go versions (GO111MODULE=auto in go 1.12, but GO111MODULE=on in go 1.13)
https://blog.golang.org/modules2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind new feature
/kind bug fix
/kind cleanup
/kind revert change
/kind design
/kind documentation
/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Test Report Added?:

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind TESTED
/kind NOT-TESTED

Test Report:

Special notes for your reviewer:
Screenshot from 2020-06-13 09-18-39

@codecov-commenter
Copy link

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   41.40%   41.40%           
=======================================
  Files          33       33           
  Lines        5598     5598           
=======================================
  Hits         2318     2318           
  Misses       2819     2819           
  Partials      461      461           

@kumarashit kumarashit added the bug Something isn't working label Jun 14, 2020
@kumarashit kumarashit added this to the JuneMid2020 milestone Jun 14, 2020
Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@skdwriting skdwriting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skdwriting skdwriting merged commit 49bb568 into sodafoundation:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants