Improve scheduling of storages to nodes #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
==========================================
+ Coverage 70.42% 70.43% +0.01%
==========================================
Files 163 163
Lines 15853 15855 +2
Branches 1961 1961
==========================================
+ Hits 11164 11167 +3
Misses 4014 4014
+ Partials 675 674 -1
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR add weight option for nodes in hashring. This will improve scheduling of performance collection of storages to nodes
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #700Special notes for your reviewer:
Following is the output for test with different WEIGHT values and resulting distribution of Storages (DATA_COUNT) to nodes
DATA_COUNT = 100000
NODE_COUNT = 3
PARTITION_SIZE = 2**5
33333: Desired data ids per node
34460: Most data ids on one node, 3.38% over
31251: Least data ids on one node, 6.25% under
DATA_COUNT = 100000
NODE_COUNT = 3
PARTITION_SIZE = 2**5
33333: Desired data ids per node
34860: Most data ids on one node, 4.58% over
30875: Least data ids on one node, 7.38% under
DATA_COUNT = 100000
NODE_COUNT = 3
PARTITION_SIZE = 2**5
33333: Desired data ids per node
34268: Most data ids on one node, 2.80% over
32478: Least data ids on one node, 2.57% under
DATA_COUNT = 100000
NODE_COUNT = 3
PARTITION_SIZE = 2**5
33333: Desired data ids per node
33490: Most data ids on one node, 0.47% over
33225: Least data ids on one node, 0.33% under
Release note: