Skip to content
This repository was archived by the owner on Jan 31, 2025. It is now read-only.

Migrate to unified core #63

Closed
electricduck opened this issue Jan 26, 2023 · 2 comments
Closed

Migrate to unified core #63

electricduck opened this issue Jan 26, 2023 · 2 comments
Assignees
Labels
💡 suggestion Something could be done

Comments

@electricduck
Copy link
Member

electricduck commented Jan 26, 2023

There is currently no track for when building without --unified-core will be obsolete, but since it is deprecated, it is worth taking a look at building Sodalite with this flag. Historically this caused problems with Sodalite and hasn't been tried since, but its worth looking at now.

Related:

@electricduck electricduck added the ⚡ enhancement Something could be better label Jan 26, 2023
@github-project-automation github-project-automation bot moved this to ✏️ Todo in Sodalite Jan 26, 2023
@electricduck electricduck added 💡 suggestion Something could be done and removed ⚡ enhancement Something could be better labels Jan 26, 2023
electricduck added a commit that referenced this issue Jan 29, 2023
electricduck added a commit that referenced this issue Jan 29, 2023
The "-unified" part of the ref triggers build.sh to run with --unified-core
@electricduck
Copy link
Member Author

It seems to work properly. Can't see any problems in the OS itself. 🤔

@electricduck electricduck self-assigned this Jan 29, 2023
@electricduck electricduck moved this from ✏️ Todo to 💥 Needs Testing in Sodalite Jan 29, 2023
@electricduck
Copy link
Member Author

electricduck commented Jun 5, 2023

This is now vital for Sodalite 5 (f38) to build, otherwise it just segfaults. build.sh has been modified in 4dade7b to use --unified-core by default, with --ex-no-unified-core added to disable building with unified core.

@github-project-automation github-project-automation bot moved this from 💥 Needs Testing to 👍 Done in Sodalite Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💡 suggestion Something could be done
Projects
Status: 👍 Done
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant