Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPARQL query #14

Closed
jgarciab opened this issue May 8, 2023 · 1 comment
Closed

SPARQL query #14

jgarciab opened this issue May 8, 2023 · 1 comment

Comments

@jgarciab
Copy link
Contributor

jgarciab commented May 8, 2023

The user should be able to specify the SPARQL query in the FIndArtWork class (init). Maybe use that one if no query is specified.

The names of the metadata (get_artist_metadata) should be extracted directly from the SPARQL database (e.g. find the names after the ?).

This would also require to merge _get_single_valued_property and _get_multi_valued_property, so one function can do both tasks. Is it not possible to detect if it's a single of multi valued property?
@jgarciab
Copy link
Contributor Author

jgarciab commented May 8, 2023

@modhurita maybe you can take a look at this?

@modhurita modhurita mentioned this issue May 16, 2023
Merged
jgarciab pushed a commit that referenced this issue May 25, 2023
@modhurita
Resolves issue #14 (#17)
fc18334 
* simplify data extraction via SPARQL query

* allow _init__ to have more than 5 parameters

* use different artist for illustration

---------

Co-authored-by: modhurita <´[email protected]´>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jgarciab