Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow automatic changes with strings #211

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Allow automatic changes with strings #211

merged 3 commits into from
Nov 29, 2023

Conversation

qubixes
Copy link
Member

@qubixes qubixes commented Nov 21, 2023

Fixes #186

New behavior is:

  • Average char count < 25 -> RegexModel
  • Average char count >= 25 && Language found -> FreeText
  • Average char count >= 25 && Language not found -> RegexModel

@qubixes qubixes marked this pull request as ready for review November 21, 2023 12:24
Copy link
Collaborator

@Samuwhale Samuwhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good one!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I shouldn't have changed it. But I keep being annoyed at it (while understanding that it is useful, especially for the online notebook hosting..

@vankesteren
Copy link
Member

merging so I can use this in my pilot today

@vankesteren vankesteren merged commit 25d4753 into main Nov 29, 2023
@vankesteren vankesteren deleted the dynamic-string branch November 29, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic selection between string distributions
3 participants