Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from AIC to BIC #212

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Change from AIC to BIC #212

merged 3 commits into from
Nov 29, 2023

Conversation

qubixes
Copy link
Member

@qubixes qubixes commented Nov 21, 2023

This seems to help a little with the multinoulli problem, at least "Age" is now correctly identified without using the multinoulli distribution. Fixes #208

Copy link
Member

@vankesteren vankesteren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If it solves the issue as you say, feel free to merge :)

Copy link
Collaborator

@Samuwhale Samuwhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too :)

@Samuwhale
Copy link
Collaborator

Although small thing - should the docstring in the information_criterion() of the BaseDistribution be changed?

@vankesteren
Copy link
Member

Merging so I can use this in my pilot today; will convert comment by @Samuwhale to issue

@vankesteren vankesteren merged commit 4680031 into main Nov 29, 2023
6 checks passed
@qubixes qubixes deleted the bic branch February 19, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multinoulli distribution is used too often.
3 participants