Discrete normal #216
Merged
Discrete normal #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice and clean! I added the tests as well, feel free to merge! |
qubixes
approved these changes
Nov 30, 2023
|
Our CI is failing on macos-latest in the nbval. Is this something we can fix easily or should I just merge? |
Samuwhale
approved these changes
Nov 30, 2023
|
You can ignore the nbval problem and merge. For some reason tests (for various previous PRs too) keep failing on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214
I am subclassing the continuous distributions. This makes the code very small but it might not be the most "clean" way of creating these discrete distributions.