Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messaging for variable fitting #347

Merged
merged 2 commits into from
Dec 9, 2024
+11 −1
Merged

Improve error messaging for variable fitting #347

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d90439
Improve error messaging for variable fitting
qubixes Nov 25, 2024
2991370
Fix erroneous mypy error
qubixes Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
Fix erroneous mypy error
@qubixes
qubixes committed Nov 25, 2024
commit 29913705516660235df7ef81ff5d898dac22c792
4 changes: 2 additions & 2 deletions metasyn/provider.py
View file
Original file line number Diff line number Diff line change
@@ -251,10 +251,10 @@ def create(self, var_spec: Union[VarSpec, VarSpecAccess]) -> BaseDistribution:
try:
return dist_class(**dist_spec.parameters)
except TypeError as err:
dist_param = set(signature(dist_class.__init__).parameters) - {"self"}
dist_param = set(signature(dist_class.__init__).parameters) - {"self"} # type: ignore
if "args" in dist_param or "kwargs" in dist_param:
raise err
unknown_param = set(dist_spec.parameters) - dist_param
unknown_param = set(dist_spec.parameters) - dist_param # type: ignore
if len(unknown_param) > 0:
raise TypeError(f"Unknown parameters {unknown_param} for variable {var_spec.name}.")
raise err