Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GTest] Fix with GCC11 #2181

Merged
merged 1 commit into from
Jun 16, 2021
Merged

[GTest] Fix with GCC11 #2181

merged 1 commit into from
Jun 16, 2021

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Jun 16, 2021

Apparently GCC11, by default, treats the "maybe uninitialized" warning as an error.
This occurs in our version of gtest.
ref: google/googletest#3219

I did not consider updating gtest itself as it could be bothersome.
And I think the "maybe uninitialized" warning as an error itself is good
(therefore no command line option fix to consider it only as a warning)


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Jun 16, 2021
@fredroy fredroy added this to the v21.06 milestone Jun 16, 2021
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 16, 2021
@epernod epernod merged commit d5b0cbc into sofa-framework:master Jun 16, 2021
@fredroy fredroy deleted the fix_gcc11 branch October 14, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants