[ODESolver] Apply new factory registration mechanism #4975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[ci-build][with-all-tests] |
fredroy
added
the
pr: status to review
|
[ci-build][with-all-tests][force-full-build] |
hugtalbot
approved these changes
Sep 10, 2024
| ; | ||
| void registerEulerImplicitSolver(sofa::core::ObjectFactory* factory) | ||
| { | ||
| factory->registerObjects(core::ObjectRegistrationData("Time integrator using implicit backward Euler scheme.") |
There was a problem hiding this comment.
coming up to my mind :
@alxbilger does our automatic scrapping for doc generation works with this new factory registration method?
There was a problem hiding this comment.
print("Dumping ObjectFactory in json...")
object_factory_data = Sofa.Core.ObjectFactory.dump_json()
The DocGenerator uses directly the ObjectFactory so the new registration wont change anything
Comment on lines
+776
to
+784
| {"CentralDifference", Dealiased("v24.12","CentralDifferenceSolver")}, | ||
| {"DampVelocity", Dealiased("v24.12","DampVelocitySolver")}, | ||
| {"RungeKutta2", Dealiased("v24.12","RungeKutta2Solver")}, | ||
| {"RungeKutta4", Dealiased("v24.12","RungeKutta4Solver")}, | ||
| {"EulerImplicit", Dealiased("v24.12","EulerImplicitSolver")}, | ||
| {"ImplicitEulerSolver", Dealiased("v24.12","EulerImplicitSolver")}, | ||
| {"ImplicitEuler", Dealiased("v24.12","EulerImplicitSolver")}, | ||
| {"VariationalSolver", Dealiased("v24.12","VariationalSymplecticSolver")}, | ||
|
|
There was a problem hiding this comment.
Sweet !
Nice alias cleaning 👍 (this will please @damienmarchal :) )
epernod
approved these changes
Sep 16, 2024
epernod
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if