Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] ObjectFactory: remove message when a plugin has already registered its components #5271

Merged

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Feb 13, 2025

Because it will appear quite often due to :

  • the auto-loading mechanism
  • the "meta-module" feature

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Feb 13, 2025
@bakpaul
Copy link
Contributor

bakpaul commented Feb 13, 2025

You can deactivate it through SOFA_WITH_DEV_TOOL, isn't it sufficient ? We can put SOFA_WITH_DEV_TOOLS at OFF by default instead ?

@fredroy
Copy link
Contributor Author

fredroy commented Feb 13, 2025

You can deactivate it through SOFA_WITH_DEV_TOOL, isn't it sufficient ? We can put SOFA_WITH_DEV_TOOLS at OFF by default instead ?

In my case I am using python directly (so no autoloading) and no meta-module so I am not really affected ; but I can see some developers annoyed by the massive amount of warnings. You may want to have some dmsg_* for other things in the code... It is all or nothing 🧐

@epernod
Copy link
Contributor

epernod commented Feb 20, 2025

I confirm I have it everywhere .... while working on SOFA or in Unity :/

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 26, 2025
@hugtalbot hugtalbot merged commit 8b3e3c0 into sofa-framework:master Feb 27, 2025
15 checks passed
@hugtalbot hugtalbot deleted the remove_already_registered_message branch February 27, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants