-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mapping] Add distance to plane mapping #5293
Open
bakpaul
wants to merge
10
commits into
sofa-framework:master
Choose a base branch
from
bakpaul:25_02_add_distance_to_plane_mapping
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Mapping] Add distance to plane mapping #5293
bakpaul
wants to merge
10
commits into
sofa-framework:master
from
bakpaul:25_02_add_distance_to_plane_mapping
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugtalbot
reviewed
Feb 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ! I will give a try to the example scene.
Even better would be an associated doc page .. 👼
Sofa/Component/Mapping/Linear/tests/DistanceToPlaneMapping_test.cpp
Outdated
Show resolved
Hide resolved
Sofa/Component/Mapping/Linear/src/sofa/component/mapping/linear/DistanceToPlaneMapping.inl
Outdated
Show resolved
Hide resolved
Sofa/Component/Mapping/Linear/src/sofa/component/mapping/linear/DistanceToPlaneMapping.inl
Outdated
Show resolved
Hide resolved
Sofa/Component/Mapping/Linear/src/sofa/component/mapping/linear/DistanceToPlaneMapping.inl
Outdated
Show resolved
Hide resolved
Sofa/Component/Mapping/Linear/src/sofa/component/mapping/linear/DistanceToPlaneMapping.inl
Outdated
Show resolved
Hide resolved
[ci-build][with-all-tests] |
2588019
to
efedeb7
Compare
Sofa/Component/Mapping/Linear/src/sofa/component/mapping/linear/DistanceToPlaneMapping.inl
Outdated
Show resolved
Hide resolved
Sofa/Component/Mapping/Linear/src/sofa/component/mapping/linear/DistanceToPlaneMapping.inl
Outdated
Show resolved
Hide resolved
Sofa/Component/Mapping/Linear/tests/DistanceToPlaneMapping_test.cpp
Outdated
Show resolved
Hide resolved
873049d
to
5e61aa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: new feature
Implement a new feature
pr: status to review
To notify reviewers to review this pull-request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new linear mapping computing a distance to a plane. The idea is to then use it to apply constraints to stay on a plane for instance (what some might call sliding constraints) or contact. The contact part is currently more tricky because there is no current way to simply add UnilateralLagrangianConstraint to a mstate --> a PR doing this will come in the future.
Parametrization is simple : a normal and a random point on the plane (used ton compute the distance to the origin. Actually only a scalar might have been sufficient, but it is easier to compute a point respecting this with the distance in mind rather than the distance with a random point, even if it is just a scalar product)
Added scene test + extensive unit testing
Will only work in position for rigid.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if