-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metadata digest api #253
metadata digest api #253
Conversation
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
============================================
+ Coverage 76.60% 76.62% +0.01%
Complexity 48 48
============================================
Files 439 439
Lines 15471 15475 +4
Branches 1505 1505
============================================
+ Hits 11852 11858 +6
Misses 2958 2958
+ Partials 661 659 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -128,6 +135,20 @@ public void init() { | |||
ReporterUtils.startSlf4jReporter(60, metrics); | |||
} | |||
|
|||
@GET | |||
@Path("/data/queryDetail") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
path冲突了
@Path("/data/queryDetail") | ||
@Produces(MediaType.APPLICATION_JSON) | ||
public Map<String, InterfaceMapping> allServiceMapping() { | ||
return interfaceAppsRepository.allServiceMapping(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
InterfaceMapping 没有空构造函数,需要确认能否被json序列化
Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.