Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata digest api #253

Merged
merged 1 commit into from
Aug 9, 2022
Merged

metadata digest api #253

merged 1 commit into from
Aug 9, 2022

Conversation

nocvalight
Copy link
Member

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@nocvalight nocvalight added this to the 6.1.6 milestone Aug 4, 2022
@nocvalight nocvalight requested a review from dzdx August 4, 2022 07:35
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #253 (f641cf3) into master (b802ace) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #253      +/-   ##
============================================
+ Coverage     76.60%   76.62%   +0.01%     
  Complexity       48       48              
============================================
  Files           439      439              
  Lines         15471    15475       +4     
  Branches       1505     1505              
============================================
+ Hits          11852    11858       +6     
  Misses         2958     2958              
+ Partials        661      659       -2     
Impacted Files Coverage Δ
...try/jdbc/repository/impl/AppRevisionContainer.java 92.30% <0.00%> (-7.70%) ⬇️
...dbc/repository/impl/AppRevisionJdbcRepository.java 69.72% <0.00%> (-0.65%) ⬇️
...c/repository/impl/InterfaceAppsIndexContainer.java 96.29% <0.00%> (-3.71%) ⬇️
...c/repository/impl/InterfaceAppsJdbcRepository.java 73.84% <0.00%> (-1.16%) ⬇️
...ta/lease/impl/DefaultCrossDcMetaServerManager.java 86.15% <0.00%> (+1.53%) ⬆️
...stry/server/session/store/AbstractDataManager.java 79.04% <0.00%> (+1.90%) ⬆️
...ofa/registry/server/session/store/DataIndexer.java 90.32% <0.00%> (+4.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b802ace...f641cf3. Read the comment docs.

Copy link
Member

@dzdx dzdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dzdx dzdx merged commit 49f7659 into sofastack:master Aug 9, 2022
@@ -128,6 +135,20 @@ public void init() {
ReporterUtils.startSlf4jReporter(60, metrics);
}

@GET
@Path("/data/queryDetail")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path冲突了

@Path("/data/queryDetail")
@Produces(MediaType.APPLICATION_JSON)
public Map<String, InterfaceMapping> allServiceMapping() {
return interfaceAppsRepository.allServiceMapping();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InterfaceMapping 没有空构造函数,需要确认能否被json序列化

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants