feat : 전역적 예외처리 로직 생성 및 Success,ErrorResponse 리팩토링 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(CC-114)
(CC-114)
putdata
requested changes
Aug 5, 2024
| public class HealthTestController { | ||
| @GetMapping("/api/health") | ||
| public ResponseEntity<SuccessResponse<String>> healthTest() { | ||
| return ResponseEntity.ok(new SuccessResponse<>(1000,"api health test에 성공했습니다.","health test v1")); | ||
| return SuccessResponse.of(SuccessCode.OK,"Caecae Spring Server Health Test ~!"); |
| public class ErrorResponse extends BaseResponse { | ||
|
|
||
| private ErrorResponse(ErrorCode errorCode) { | ||
| super(errorCode.getResponseCode(),errorCode.getMessage()); |
| */ | ||
| @Getter | ||
| @AllArgsConstructor(access = AccessLevel.PROTECTED) | ||
| public enum ErrorCode implements BaseCode{ |
| /** | ||
| * 1000 : 틀린그림찾기 | ||
| */ | ||
| NOT_FOUND(1000, "잘못된 요청입니다.",HttpStatus.NOT_FOUND), |
| /** | ||
| * 2xxx : 레이싱게임 .. | ||
| */ | ||
| NEED_AUTHENICATE(1000, "권한이 필요한 요청입니다,",HttpStatus.UNAUTHORIZED), |
| */ | ||
| @Getter | ||
| @AllArgsConstructor(access = AccessLevel.PROTECTED) | ||
| public enum SuccessCode implements BaseCode{ |
| /** | ||
| * 1000 : 틀린그림찾기 | ||
| */ | ||
| OK(1000, "요청이 성공했습니다.",HttpStatus.OK), |
| CREATED(1001,"생성 요청이 성공했습니다.",HttpStatus.CREATED), | ||
| USER_CREATED(1001,"유저 회원가입이 성공했습니다.",HttpStatus.CREATED), | ||
| TEAM_CREATED(1001,"팀 등록에 성공했습니다.",HttpStatus.CREATED); | ||
|
|
| super(errorCode.getMessage()); | ||
| this.errorCode = errorCode; | ||
|
|
||
|
|
| super(errorCode.getMessage()); | ||
| this.errorCode = errorCode; | ||
|
|
||
|
|
(CC-114)
…#13) * test : 서버 health check 컨트롤러 테스트 코드 작성 (CC-111) * test : 서버 health check 컨트롤러 테스트 코드 작성 (CC-111) * test : 서버 health check 컨트롤러 테스트 코드 작성 (CC-111) * feat : S3 컨트롤러에 responseEntity 설정 (CC-111) * test : S3 통합테스트 환경 disabled (CC-111) * docs : Pull Request template 업로드 (CC-111) * rename : S3 controller 디렉터리 수정 (CC-111)
(CC-114)
(CC-114)
(CC-114)
(CC-114)
putdata
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개발 내용
RacingGameWinner테이블의rank컬럼이 예약어여서 임시로ranking으로 수정BaseCode,SuccessCode,ErrorCode에서 관리BaseResponse,SuccessResponse,ErrorResponse클래스에서 관리GlobalException에서 발생시킴.GlobalExceptionHandler에서 발생한 에러를 캐치하여ErrorResponse로 반환{Domain}Exception과{Domain}ExceptionHandler를 생성하여 도메인 별로 에러를 관리할 것