Form service amendment #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGenash
force-pushed
the
form_service_amendment
branch
from
f8b3919 to
565eb76
Compare
MaxGenash
force-pushed
the
form_service_amendment
branch
2 times, most recently
from
8c915f1 to
d1e760f
Compare
Case: it was called validateForm and then while it hadn't finished it was called clearValidation(myField) and then several times called validateForm(). Result: the last called validateForm didn't return errors for myField though it should had because clearValidation should influence only old unfinished call of validateForm. Bug reason: _pendingClearValidation wasn't cleared in old calls of _validateForm because ThrottleErrors interrupted those calls.
MaxGenash
force-pushed
the
form_service_amendment
branch
from
d1e760f to
b0cb769
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.