Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ts validator #422

Merged
merged 4 commits into from
Jun 19, 2023
Merged

Improve ts validator #422

merged 4 commits into from
Jun 19, 2023

Conversation

kir4ik
Copy link
Contributor

@kir4ik kir4ik commented Jun 19, 2023

  • new version of Validator:
    • implements only the IValidator interface
    • need to be created via ValidatorBuilder
    • an empty instance can be created using the ValidatorBuilder.createEmptyValidator method.
  • the old version of Validator:
    • is marked as "deprecated" and is available through the deprecated factory method "createValidator"
  • fixed in code - using IValidator interface in types instead of Validator class

breaking changes

  • the Validator has been removed from the main export, there are special methods for creating an instance, as well as so that there are no unexpected problems if someone used "instanceof"

improved linter - import types by keyword "type"

kir4ik added 4 commits June 19, 2023 13:22
- new version of `Validator`:
  - implements only the `IValidator` interface
  - need to be created via ValidatorBuilder - method "createValidatorBuilder"
  - an empty instance can be created using the createEmptyValidator method.
- the old version of `Validator`:
  - is marked as "deprecated" and is available through the deprecated factory method "createValidator"
- fixed in code - using IValidator interface in types instead of Validator class

breaking changes
- the `Validator` has been removed from the main export, there are special methods for creating an instance, as well as so that there are no unexpected problems if someone used "instanceof"
@Smert Smert merged commit 245f84c into softindex:master Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants