-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release asset upload 'Deprecation' message in log output #129
Comments
Same problem for me. |
This probably came with a release updates you should be able to use @0.5.1 in the mean time https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md#015 I’ll take a look tonight |
I tried using 0.5.1 as you said, as
And it give me the following error
EDIT Sorry, my fault, it must be @v0.5.1. |
Seems like my issue was of my own making, was forcing a release on top of an already existing release (duplicate tags) or something similarly dumb. The deprecation is seemingly only a warning (appears on successful runs also) but it does make it confusing on what the actual issue is. The below 'standard' config works for me: - name: Release
uses: softprops/action-gh-release@v1 |
Fixed for me using @v0.1.6. |
Same on me https://github.com/tiddly-gittly/TiddlyGit-Desktop/runs/3174941044?check_suite_focus=true
I think in this time, I am using @v0.1.6. |
I can reproduce the warnings but not yet the error. I have a test run here (sample run output below)
a warning is an indicator that I need to upgrade something but should not fail your build. which makes this a bit less urgent for me. something that I can perhaps get to this weekend @linonetwo it looks like in your case the real error isn't related to the warnings but the error that followed
This indicates that you may have already uploaded a release asset of the same name causing a conflict which I believe is failing your build. I'd need to see your workflow setup to get a better sense for how the release asset might have been previously uploaded. That said, upserting (updating or creating) assets is something I'd love to add support for in this gh action |
Thank you @softprops , my workflow is https://github.com/tiddly-gittly/TiddlyGit-Desktop/blob/c0c979a1fb01648cdc1df57a033485bbe57d7a20/.github/workflows/release.yml#L151-L175 I upload files in a folder, so there can't be two file with same name... It is not easy to know which file is in conflict, hope there can be a log about file name. I have three upload for each platform, so maybe they upload a metadata file that have same name? Hope I can just ignore this warning, just like what it does before... |
Would it be possible to add an ls directory listing in the step prior to debug? |
Seems two windows build make same |
Same problem here: https://github.com/Loyalsoldier/v2ray-rules-dat/runs/3176493282?check_suite_focus=true In the above workflows, assets were uploaded successfully, but the workflows step failed with deprecation notice. |
I limit the uploaded file to only |
I see the same problem in our build with regards to duplicate uploads. However, AFAIK duplicate uploads worked for us before, so I assume there is some regression that changed this behavior? In addition, the error is logged as HTML text with a base64 encoded image:
|
This think this regressed in the fix here #97 |
I’m going to open a separate issue to not confuse this with the deprecation warnings |
I’m going to update the title of this issue. Releases don’t fail with just the gh api warnings |
Seem many people are talking about using this action for uploading duplicated files, and I forgot to say but this is my case, I've configured my workflow to upload a new set of assets with every new commit so users can test it, the assets are disposable so they aren't versioned at all, and are always uploaded to the same tag/release.
You should consider allow overwriting the assets. |
With had glob patterns in the Create Release step which resulted in the same files being uploaded more than once, which since the last `action-gh-release` results in an error (see softprops/action-gh-release#131). Also removed the GITHUB_TOKEN env var which is not required. This step still outputs some deprecation messages, which is being addressed upstream (see softprops/action-gh-release#129)
With had glob patterns in the Create Release step which resulted in the same files being uploaded more than once, which since the last `action-gh-release` results in an error (see softprops/action-gh-release#131). Also removed the GITHUB_TOKEN env var which is not required. This step still outputs some deprecation messages, which is being addressed upstream (see softprops/action-gh-release#129)
Use the v0.1.8 and failed again (assets were uploaded successfully to github release but the workflow failed):
https://github.com/Loyalsoldier/v2ray-rules-dat/runs/3272404245?check_suite_focus=true |
Use v0.1.10 and failed again:
https://github.com/Loyalsoldier/v2ray-rules-dat/runs/3274409350?check_suite_focus=true |
With had glob patterns in the Create Release step which resulted in the same files being uploaded more than once, which since the last `action-gh-release` results in an error (see softprops/action-gh-release#131). Also removed the GITHUB_TOKEN env var which is not required. This step still outputs some deprecation messages, which is being addressed upstream (see softprops/action-gh-release#129)
With had glob patterns in the Create Release step which resulted in the same files being uploaded more than once, which since the last `action-gh-release` results in an error (see softprops/action-gh-release#131). Also removed the GITHUB_TOKEN env var which is not required. This step still outputs some deprecation messages, which is being addressed upstream (see softprops/action-gh-release#129) Signed-off-by: Sanni Michael <[email protected]>
Info
softprops/action-gh-release@v1
failed with a 'Deprecation' error.See gist link for the error message:
https://gist.github.com/nialov/e151ed3511bc55de3dae2bacb91b0ddb
Background
My workflow additionally uses:
The text was updated successfully, but these errors were encountered: