Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: big file uploads #562

Merged
merged 4 commits into from
Jan 7, 2025
Merged

fix: big file uploads #562

merged 4 commits into from
Jan 7, 2025
+29 −25

Conversation

xen0n
Copy link
Contributor

@xen0n xen0n commented Dec 23, 2024

Sorry for the broken 2.2.0 release, I've now tested this change with actual big file uploads at my testing ground repo with successful test run here.

@chenrui333: please tag a 2.2.1 release after this, thanks!

xen0n added 4 commits December 23, 2024 15:06
@xen0n
fix: use readableWebStream() to stream asset contents
0b3b1e3 
This allows the uploads to finish without mismatched Content-Length,
likely because the original method implied a wrong body encoding or
something similar. Unfortunately a GitHub server API mock was not
readily available so I had to test manually with a barebones repository.

Fixes: softprops#555
Fixes: softprops#556
Signed-off-by: WANG Xuerui <[email protected]>
@xen0n
feat: log when each asset is successfully uploaded
3b7f7ff 
Signed-off-by: WANG Xuerui <[email protected]>
@xen0n
build: refresh dist
f5f5520 
Signed-off-by: WANG Xuerui <[email protected]>
@xen0n
style: format with prettier
d67838e 
Signed-off-by: WANG Xuerui <[email protected]>
This was referenced Dec 23, 2024
Closed
Closed
@bramkragten bramkragten mentioned this pull request Dec 23, 2024
Merged
@zirain zirain mentioned this pull request Dec 25, 2024
Open
@itay-sho
Copy link

Thanks for the fix!
@softprops any plans to get it merged soon?

@chrischdi chrischdi mentioned this pull request Dec 26, 2024
Closed
@jpelgrom jpelgrom mentioned this pull request Dec 27, 2024
Merged
@silamon silamon mentioned this pull request Dec 30, 2024
Draft
@xen0n xen0n mentioned this pull request Dec 30, 2024
Merged
JP-Ellis added a commit to pact-foundation/pact-python that referenced this pull request Dec 30, 2024
@JP-Ellis
Revert "chore(deps): update softprops/action-gh-release action to v2.…
6aad6b2 
…2.0"

This reverts commit 15f61ca.

There's a bug in softprops 'action-gh-release' action which appears when
uploading larger assets. Reverting to an earlier version until fix is merged.

Ref: softprops/action-gh-release#562
Ref: softprops/action-gh-release#556
Signed-off-by: JP-Ellis <[email protected]>
@JP-Ellis JP-Ellis mentioned this pull request Dec 30, 2024
Merged
JP-Ellis added a commit to pact-foundation/pact-python that referenced this pull request Dec 30, 2024
@JP-Ellis
Revert "chore(deps): update softprops/action-gh-release action to v2.…
5a71da0 
…2.0"

This reverts commit 15f61ca.

There's a bug in softprops 'action-gh-release' action which appears when
uploading larger assets. Reverting to an earlier version until fix is merged.

Ref: softprops/action-gh-release#562
Ref: softprops/action-gh-release#556
Signed-off-by: JP-Ellis <[email protected]>
@pattacini
Copy link

Hi @softprops

I've tested the PR and it worked for my case as reported in #552 (comment).
I would need a proper release for my workflow though.

@xen0n
Copy link
Contributor Author

xen0n commented Jan 1, 2025

Hi @softprops

I've tested the PR and it worked for my case as reported in #552 (comment). I would need a proper release for my workflow though.

Good to hear and Happy New Year 🎉!

I would have to wait for either @softprops or @chenrui333 to make the release though... I'm new to the project so I don't have the permission to tag the release yet. (Or I would have merged this the day I submitted it.)

@brooksmtownsend brooksmtownsend mentioned this pull request Jan 3, 2025
Merged
ubhaller added a commit to UbiqueInnovation/workflows-backend that referenced this pull request Jan 4, 2025
@ubhaller
current softpops/action-gh-release action is broken. revert to workin…
e86587c 
…g version

softprops/action-gh-release#562
@clintonsteiner
Copy link

clintonsteiner commented Jan 6, 2025 •
edited
Loading

@chenrui333 @softprops please assist with getting this merged

Find lots of packages experiencing and tagging to 2.1.0 instead of latest due to this issue
#555

This is all work that will need undone once 2.2.1 is released

@clintonsteiner
Copy link

@xen0n can you add changelog notes for the release of 2.2.1 advising users to not take that due to an error

@chenrui333 chenrui333 changed the title Fix big file uploads fix: big file uploads Jan 7, 2025
@chenrui333 chenrui333 merged commit deddb09 into softprops:master Jan 7, 2025
1 check passed
@chenrui333
Copy link
Collaborator

my bad, gonna release this change now.

@chenrui333 chenrui333 added the bug Something isn't working label Jan 7, 2025
@chenrui333
Copy link
Collaborator

cut the new 2.2.1 release, thanks!

@pattacini
Copy link

Thanks heaps!

@rumstead rumstead mentioned this pull request Jan 7, 2025
Merged
14 tasks
@xen0n xen0n deleted the fix-big-file-upload branch January 7, 2025 23:26
@basil basil mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xen0n @itay-sho @pattacini @clintonsteiner @chenrui333