-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Web LA] Add warning about transform
#6064
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
@tjzel/monorepo-remove-reanimated2
to
@tjzel/monorepo
June 5, 2024 15:36
szydlovsky
reviewed
Jun 13, 2024
szydlovsky
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but let's see what @piaskowyk has to say 👀
And please fix lint
piaskowyk
approved these changes
Jun 14, 2024
packages/react-native-reanimated/src/layoutReanimation/web/animationsManager.ts
Outdated
Show resolved
Hide resolved
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #6060 I've removed adding already existing transform into layout animations on web (you can read more about reasoning in the mentioned PR). This PR adds
warning
for users that suggests creating animated wrapper ifAnimated.View
with layout animation containstransform
instyle
.Test plan
Tested on example app (
MountingUnmounting
example) and on the following code:Test code