Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(example): update readme with build step #6089

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

frankcalise
Copy link
Contributor

Summary

I had trouble running the Example app after following the README steps. After building from the root of the monorepo, the iOS app began working so I updated the documentation steps.

Test plan

  1. Clone the react-native-reanimated repository
  2. Follow step exactly in Example/README.md and observe the iOS app will not start
  3. Go back to the root of the monorepo and run yarn build
  4. cd Example && yarn ios should now work successfully

Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@tomekzaw tomekzaw added this pull request to the merge queue Jun 11, 2024
Merged via the queue into software-mansion:main with commit 14cf3ec Jun 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants