Fix getAnimatedStyle
error when called with component that doesn't have animated styles
#6746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isEmpty
will returnfalse
if it is passed inundefined
, instead of throwing an error.Summary
If
getAnimatedStyle
is passed in a component that doesn't have animated styles, it throws an error saying "Cannot convert undefined or null to object". This happens becausejestUtils.ts
has anisEmpty
function that callsObject.keys
with an argument that can potentially beundefined
. The arg can potentially beundefined
because it comes fromconst jestAnimatedStyleValue = component.props.jestAnimatedStyle?.value;
This issue was introduced in version 3.16.0.
Test plan
Can be simply tested on a browser console. Just run:
(obj => Object.keys(obj).length === 0)(undefined) // throws error
(obj => !obj || Object.keys(obj).length === 0)(undefined) // returns true as expected
(obj => !obj || Object.keys(obj).length === 0)({test: 'something'}) // returns false as expected