Don't call jsQueue->quitSynchronous() immediately after construction
#6781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
I've tested it against some configuration and everything seems to works:
- Android, debug, Hermes, Fabric
- Android, release, Hermes, Fabric
- iOS, debug, Hermes, Fabric
- iOS, debug, JSC, Fabric
- iOS, release, JSC, Fabric
- MacOS, debug, JSC, Paper
- MacOS, release, JSC, Paper
- TVOS, debug, Hermes, Fabric
- Android, debug, Hermes, Paper
- iOS, debug, Hermes, Paper
- iOS, release, Hermes, Paper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves
jsQueue->quitSynchronously()calls fromReanimatedRuntime::makeorReanimatedHermesRuntimeconstructor to~WorkletsModuleProxyas well as simplifies the logic.I had to add
(void)jsQueue;to avoid a warning due to unused variable.Test plan
Note
I have tested this PR only on iOS Fabric in debug mode. Please test it thoroughly across platforms, runtimes and build configurations prior to merging.