Remove REAInitializerRCTFabricSurface
#6837
Conversation
|
Finally! 😮 |
| } | ||
|
|
||
| - (void)attachReactEventListener | ||
| - (void)attachReactEventListener:(std::shared_ptr<ReanimatedModuleProxy>)reanimatedModuleProxy |
There was a problem hiding this comment.
| - (void)attachReactEventListener:(std::shared_ptr<ReanimatedModuleProxy>)reanimatedModuleProxy | |
| - (void)attachReactEventListener:(const std::shared_ptr<ReanimatedModuleProxy> &)reanimatedModuleProxy |
There was a problem hiding this comment.
Here, I can't pass a reference to a pointer because attachReactEventListener is called with a local pointer. If I pass a reference to smart pointer here and use that reference asynchronously in a block, the pointer will already be destroyed :/
| [scheduler addEventListener:eventListener]; | ||
| } | ||
| auto eventListener = | ||
| std::make_shared<facebook::react::EventListener>([reanimatedModuleProxy](const RawEvent &rawEvent) { |
There was a problem hiding this comment.
Maybe we should pass reanimatedModuleProxy as std::weak_ptr?
There was a problem hiding this comment.
I think using a shared pointer should be fine, but just to be safe, we could use a weak_ptr instead 🫡
@WoLewicki That PR also drops support for bridge-full mode |
Summary
This PR cleans up the Reanimated initialization process for iOS on Fabric. The primary motivation for these changes is to remove
REAInitializerRCTFabricSurface, which was used as a workaround to access the surface presenter on the new architecture in bridge-full mode.Test plan
I need to wait until the reload issue is fixed on the main branch 😞