-
-
Notifications
You must be signed in to change notification settings - Fork 533
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: make unstable_sheetFooter usable with react-navigation v7 (#2504)
## Description Associated PR: * react-navigation/react-navigation#12258 The footer is currently broken, as in the effect of recent refactors it erroneously ended up being rendered as child as `ScreenStackItem`, thus due to internal implementation it is rendered under `ScreenContentWrapper`. However, it has to be rendered as direct child of `Screen` component (the same as `HeaderConfig`). Under usual circumstances this would be a breaking change, however the prop is marked as `unstable`, therefore I'm proceeding. ## Changes `unstable_sheetFooter` is now rendered by `ScreenStackItem`. ## Test code and steps to reproduce `Test1649` ## Checklist - [ ] Ensured that CI passes
- Loading branch information
Showing
3 changed files
with
16 additions
and
1 deletion.
There are no files selected for viewing
Submodule react-navigation
updated
26 files
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters