Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iOS): change implementation of calculating status bar, refactor methods used on header height change #1917
fix(iOS): change implementation of calculating status bar, refactor methods used on header height change #1917
Changes from 8 commits
83c8abc
2d8592c
dda38c3
6e3cbb9
46364e5
9529047
8884bef
40df2fd
3d4bd36
4f45e5f
9c0a332
e910699
b0243c7
dc987c6
686a221
e779764
add6ee3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment from me - leaving the name
calculateHeaderHeightIsModal
is made on purpose here. I did not change it tocalculateNavigationBarHeightIsModal
because for meheader
is the navigationBar + an inset of it - that's why I'm leaving it here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case I'm not sure, so we can leave it, but I have a feeling that it is also always
RNSScreen
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it for now - I'm afraid if there will be some cases that
vc
won't be actually RNSScreen (RNSScreenStack?) and that may cause some crashes on iOS.